Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: opera (original, original-wordmark) #730

Merged
merged 11 commits into from
Jul 22, 2021
Merged

new icon: opera (original, original-wordmark) #730

merged 11 commits into from
Jul 22, 2021

Conversation

MichielPater
Copy link
Contributor

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/opera/opera-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/opera/opera-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

icons/opera/opera-original-wordmark.svg Outdated Show resolved Hide resolved
icons/opera/opera-original.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
MichielPater and others added 3 commits July 7, 2021 21:31
Co-authored-by: David Leal <halfpacho@gmail.com>
Added opera aliases

Co-authored-by: David Leal <halfpacho@gmail.com>
Updated viewport for opera

Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting ',' delimiter: line 2821 column 13 (char 59466)

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

@amacado @Panquesito7 what do you think about the white lines in the icon? This is caused by the gradient in the original version. I'm a bit iffy on this in terms of quality. Should the icon not have that line?

@Panquesito7
Copy link
Member

@amacado, @Panquesito7, what do you think about the white lines in the icon? This is caused by the gradient in the original version. I'm a bit iffy on this in terms of quality. Should the icon not have that line?

I think that should be removed. If you look at it quickly, it looks fine. But if you look at it carefully, it doesn't look so good.

@Thomas-Boi
Copy link
Member

@amacado, @Panquesito7, what do you think about the white lines in the icon? This is caused by the gradient in the original version. I'm a bit iffy on this in terms of quality. Should the icon not have that line?

I think that should be removed. If you look at it quickly, it looks fine. But if you look at it carefully, it doesn't look so good.

I agree. In that case, @MichielPater can you make a plain version please? The originals look good so keep both. Just copy and paste opera-original to opera-plain then remove the gradients. Basically, by the end of it, you should have one continuous red O. This should be feasible in an SVG editor. Don't forget to update the devicon.json appropriately too (add entry in font, remove it in alias, etc.)

Extra Credit: Do the same thing for the original-wordmark version if you have time. Just make sure that the plain-wordmark SVG only contains 1 color => the Opera word should also be the same red color as the logo. If you don't have time, just the plain version is enough.

devicon.json Outdated Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 22, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @MichielPater!

Good job, I'll merge this PR into develop.

For the other maintainers: don't worry, I checked for whether the SVGs contain strokes. The new SVGs don't have them.

@Thomas-Boi Thomas-Boi dismissed Panquesito7’s stale review July 22, 2021 02:46

Most of the issues have been addressed. As for the aliases, I'd say we let that slide.

@Thomas-Boi Thomas-Boi merged commit 58d0cf7 into devicons:develop Jul 22, 2021
@Panquesito7 Panquesito7 linked an issue Aug 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Opera
3 participants