-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: opera (original, original-wordmark) #730
Conversation
MichielPater
commented
Jul 7, 2021
- Fix Issue Icon request: Opera #722
- Fix Issue #722
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Co-authored-by: David Leal <halfpacho@gmail.com>
Added opera aliases Co-authored-by: David Leal <halfpacho@gmail.com>
Updated viewport for opera Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
@amacado @Panquesito7 what do you think about the white lines in the icon? This is caused by the gradient in the |
I think that should be removed. If you look at it quickly, it looks fine. But if you look at it carefully, it doesn't look so good. |
I agree. In that case, @MichielPater can you make a Extra Credit: Do the same thing for the |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @MichielPater!
Good job, I'll merge this PR into develop
.
For the other maintainers: don't worry, I checked for whether the SVGs contain strokes. The new SVGs don't have them.
Most of the issues have been addressed. As for the aliases
, I'd say we let that slide.