-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: socketio (original, original-wordmark, plain, plain-wordmark) #744
Conversation
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com>
…/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com>
…/lodash-4.17.21 Bump lodash from 4.17.20 to 4.17.21
Release v2.12.0
(cherry picked from commit 397c9b5)
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your SVGs look great; we just have a few issues with the devicon.json
but they are easily fixed.
devicon.json
Outdated
"plain", | ||
"plain-wordmark" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For font
, please put the SVG versions that are font-friendly here. The non-existent SVG versions should go in aliases
.
Also, I'd recommend not using aliases
anymore. We'll eventually phase it out in the future. We'll update the docs as well so people know our intentions.
"plain", | |
"plain-wordmark" | |
"original", | |
"original-wordmark" |
devicon.json
Outdated
"original-wordmark", | ||
"plain", | ||
"plain-wordmark" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions don't exist so don't put them here.
"original-wordmark", | |
"plain", | |
"plain-wordmark" | |
"original-wordmark" |
The icons are now scaled for their 128x viewboxes, and I've removed the |
This comment has been minimized.
This comment has been minimized.
Hey @TheFoxarmy, Great work! The icons look great! I just need you to scale down the wordmark version and I'll accept the PR. The edges on the sides are cut off a little bit; can you please scale the SVG objects down so there's some margins on the side? Just a little bit is good |
For me, that looks good (if it's exact to the |
Aight, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 😄
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @TheFoxarmy! Thank you for your contribution! 👍 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, the icon looks good now. Thank you for your work and welcome to the repo @TheFoxarmy
…k) (devicons#744) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * Created original & wordmark icon for Socket.IO (cherry picked from commit 397c9b5) * Resized icons to 128x viewbox, removed aliases & plain. * Made wordmark icon flush with viewbox so it won't be cut off. * Update devicon.json to include aliases Co-authored-by: David Leal <halfpacho@gmail.com> * added end line to original Co-authored-by: David Leal <halfpacho@gmail.com> * added newline to wordmark Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com>
Created an icon for the real-time WebSockets library Socket.IO
https://socket.io/
I just separated the SVG from the site into its own icon and removed the white background and minified as much as possible. The icon was simple enough for a single plain version.
Addresses issue #370