Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: socketio (original, original-wordmark, plain, plain-wordmark) #744

Merged
merged 13 commits into from
Jul 12, 2021

Conversation

FlorianEagox
Copy link
Contributor

Created an icon for the real-time WebSockets library Socket.IO
https://socket.io/
I just separated the SVG from the site into its own icon and removed the white background and minified as much as possible. The icon was simple enough for a single plain version.
Addresses issue #370

dependabot bot and others added 6 commits May 11, 2021 02:39
…/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
…/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi Thomas-Boi changed the base branch from master to develop July 10, 2021 19:17
@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/socketio/socketio-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/socketio/socketio-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your SVGs look great; we just have a few issues with the devicon.json but they are easily fixed.

devicon.json Outdated
Comment on lines 3328 to 3329
"plain",
"plain-wordmark"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For font, please put the SVG versions that are font-friendly here. The non-existent SVG versions should go in aliases.

Also, I'd recommend not using aliases anymore. We'll eventually phase it out in the future. We'll update the docs as well so people know our intentions.

Suggested change
"plain",
"plain-wordmark"
"original",
"original-wordmark"

devicon.json Outdated
Comment on lines 3323 to 3325
"original-wordmark",
"plain",
"plain-wordmark"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions don't exist so don't put them here.

Suggested change
"original-wordmark",
"plain",
"plain-wordmark"
"original-wordmark"

devicon.json Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 10, 2021
@FlorianEagox
Copy link
Contributor Author

The icons are now scaled for their 128x viewboxes, and I've removed the plain & aliases from devicon.json

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 12, 2021
@github-actions

This comment has been minimized.

@Thomas-Boi
Copy link
Member

Hey @TheFoxarmy,

Great work! The icons look great! I just need you to scale down the wordmark version and I'll accept the PR. The edges on the sides are cut off a little bit; can you please scale the SVG objects down so there's some margins on the side? Just a little bit is good

@FlorianEagox
Copy link
Contributor Author

hi, so I've adjusted the boundaries of the icon to be exactly at the viewbox to remove that tiny bit cutting off as seen here:
image
Would you like it like that, or do you actually want a bit of whitespace/margin on the icon?

@Panquesito7
Copy link
Member

Would you like it like that

For me, that looks good (if it's exact to the viewBox size). Thanks. 👍

@FlorianEagox
Copy link
Contributor Author

Aight, fixed

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

devicon.json Outdated Show resolved Hide resolved
icons/socketio/socketio-original-wordmark.svg Outdated Show resolved Hide resolved
icons/socketio/socketio-original.svg Outdated Show resolved Hide resolved
FlorianEagox and others added 3 commits July 11, 2021 21:05
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 12, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @TheFoxarmy! Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 requested a review from Thomas-Boi July 12, 2021 02:09
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the icon looks good now. Thank you for your work and welcome to the repo @TheFoxarmy

@Thomas-Boi Thomas-Boi merged commit b7fdc5a into devicons:develop Jul 12, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…k) (devicons#744)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

* Created original & wordmark icon for Socket.IO

(cherry picked from commit 397c9b5)

* Resized icons to 128x viewbox, removed aliases & plain.

* Made wordmark icon flush with viewbox so it won't be cut off.

* Update devicon.json to include aliases

Co-authored-by: David Leal <halfpacho@gmail.com>

* added end line to original

Co-authored-by: David Leal <halfpacho@gmail.com>

* added newline to wordmark

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants