Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: processing (original, original-wordmark, plain, plain-wordmark) #747

Merged
merged 20 commits into from
Jul 14, 2021
Merged

new icon: processing (original, original-wordmark, plain, plain-wordmark) #747

merged 20 commits into from
Jul 14, 2021

Conversation

FlorianEagox
Copy link
Contributor

@FlorianEagox FlorianEagox commented Jul 12, 2021 •
edited
Loading

Addresses issue #716
I used this image to create an SVG from scratch:
image
I'm not sure how to optimize the SVG too well since it has a lot of objects.
If the original is too busy, we can just use the plain version, though.
image
For the text versions, I've used black text, but I can make it white if preferred.

dependabot bot and others added 14 commits May 11, 2021 02:39
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
3436ea2 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#603 from devicons/dependabot/npm_and_yarn…
563d9cf 
…/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@dependabot
Bump lodash from 4.17.20 to 4.17.21
c259984 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#604 from devicons/dependabot/npm_and_yarn…
7a4ca8a 
…/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi
Merge pull request devicons#682 from devicons/develop
9f4f5cd 
Release v2.12.0
@FlorianEagox
Added nuxt icon from their design guide
3c9fe60 
created new logo + text icon
@FlorianEagox
Created plain version of nuxtjs & optimized original
90b72e3
@FlorianEagox
removed unnecessary XML declarations.
618605a
@FlorianEagox
Changed viewbox to 128x for all icons
8b5997d
@FlorianEagox
Merge branch 'develop' into master
8593582
@FlorianEagox
Added plain processing icon
4dc108d
@FlorianEagox
Vectorized processing icon
53d9f62
@FlorianEagox
Added wordmark versions of processing icon & updated JSON
1d927f2
@FlorianEagox
Added text versions, made minor change to put one line below others.
192446c
@Thomas-Boi Thomas-Boi changed the base branch from master to develop July 13, 2021 17:14
@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 13, 2021
@Thomas-Boi
Copy link
Member

Hi @TheFoxarmy,

Just a few things that I notice:

  • The wordmark SVGs are named text. Please rename them to wordmark instead.
  • Please ensure that you open a PR into develop and not master for future PR.
  • Make sure that the PR name matches the standard laid out here

Panquesito7
Panquesito7 requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @Thomas-Boi said, please rename the processing-plain-text.svg file to processing-plain-wordmark.svg. Also rename the processing-original-text.svg file to processing-original-wordmark.svg.

Panquesito7
Panquesito7 requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions optimize the SVGs for less size with the same quality.

icons/processing/processing-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/processing/processing-original-wordmark.svg Outdated Show resolved Hide resolved
FlorianEagox and others added 2 commits July 13, 2021 18:32
@FlorianEagox @Panquesito7
optimized plain-wordmark
9f40706 
Co-authored-by: David Leal <halfpacho@gmail.com>
@FlorianEagox @Panquesito7
optimized wordmark
22bb345 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 changed the title new icon processing (original, original-wordmark, plain, plain-wordmark) new icon: processing (original, original-wordmark, plain, plain-wordmark) Jul 13, 2021
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 13, 2021
@github-actions

This comment has been minimized.

Sign in to view
Panquesito7
Panquesito7 requested changes Jul 13, 2021
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@FlorianEagox @Panquesito7
changed fonts to font
f735065 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 13, 2021
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 13, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution, @TheFoxarmy! 👍 🎉

@Thomas-Boi
Copy link
Member

This PR looks good. Great job @TheFoxarmy!

@Thomas-Boi Thomas-Boi merged commit 2b20fad into devicons:develop Jul 14, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Thomas-Boi Thomas-Boi Awaiting requested review from Thomas-Boi

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorianEagox @Thomas-Boi @Panquesito7