Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to npm name #756

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Publish to npm name #756

merged 1 commit into from
Jul 17, 2021

Conversation

roythearsonist
Copy link
Contributor

The workflow for publish to npm doesn't have a

name:

so I added it

@roythearsonist
Copy link
Contributor Author

Whoops wrong branch to merge to can someone change it

@Panquesito7 Panquesito7 changed the base branch from master to develop July 17, 2021 01:29
Panquesito7
Panquesito7 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Panquesito7 Panquesito7 requested a review from Thomas-Boi July 17, 2021 01:30
@roythearsonist
Copy link
Contributor Author

Thanks!

Thanks to you for changing the branch

@amacado amacado merged commit 3138687 into devicons:develop Jul 17, 2021
@roythearsonist roythearsonist deleted the npmworkflowname branch July 17, 2021 16:19
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@amacado
name for npm-publish workflow (devicons#756)
d47a257 
Publish to npm name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Thomas-Boi Thomas-Boi Awaiting requested review from Thomas-Boi

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roythearsonist @amacado @Panquesito7