Gulpfile Edits

[roythearsonist]

Makes Gulpfile look better

[Thomas-Boi]

Overall, the suggested changes are good and I appreciate them. However, there are a few that don't fit the repo's style, such arrow callback with one argument using parentheses or dangling commas in objects.

If you can address those issues, the PR is good to go. Do take a look at the file to make sure everything is gone though, I might have miss some of them.

[Thomas-Boi]

For future references, please avoid making PRs that contains only stylistic changes that don't bring a lot of benefits to the repo. If you are refactoring an absolute mess of a file, that'll be greatly appreciated. However, for files like the gulpfile that don't get worked on often, this is unnecessary.

I know that many of the files are not 100% up to industry gold standards. However, they do meet many of these stylistic standards (readable code, properly commented) and they work. Furthermore, this is a hobby. I don't want to force everyone to follow every small stylistic rules, hence the lack of linters in the project. Instead, if you can dedicate that time to features, that'll be much more appreciated.

[roythearsonist]

Alright. Although to be honest, that's kinda all I'm good at. But it is what it is

[Thomas-Boi]

Alright. Although to be honest, that's kinda all I'm good at. But it is what it is

You can still help out with feature request and icon reviews. Those are easy to pick up and we can always use a hand with them.

Also, thanks for fixing the issues but there are a few left. Just a tip: you can fix them quickly on the website by clicking on "Add suggestion to batch" or "Commit Suggestion"

This will let GitHub commit my changes in the PR without the need of you relooking for the suggestions.

[roythearsonist]

Just a tip: you can fix them quickly on the website by clicking on "Add suggestion to batch" or "Commit Suggestion"

Thanks, I never knew that

[Thomas-Boi]

Good work 👍. Everything looks good now.

Remember, there are many ways to contribute. Just because we don't accept some of them doesn't mean that we don't accept everything. If you want, you can also open an Issue or message us on Discord before you want to do something. That way, you don't have to lose time on your PRs.

[roythearsonist]

you can also open an Issue or message us on Discord

Can I get the link

[Thomas-Boi]

@theblobscp here you go: https://github.com/devicons/devicon#discord-server

[Panquesito7]

you can also open an Issue or message us on Discord

Can I get the link

Here's the link invitation to our Discord server: https://discord.gg/hScy8KWACQ

[roythearsonist]

Thanks to you both