Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all issue templates into issue forms #764

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Convert all issue templates into issue forms #764

merged 3 commits into from
Jul 21, 2021

Conversation

Panquesito7
Copy link
Member

Things added/changed:

  • Convert all issue templates into issue forms.
    • Also disables blank issues and provides an Other issue template.

How to test

  • This would have to be merged to master to test it directly. Although, check this repository and try to submit an issue.

@Panquesito7
Convert all issue templates into issue forms
07b0024 
Also disables blank issues and provides a `Other` issue template.
@Panquesito7 Panquesito7 self-assigned this Jul 21, 2021
roythearsonist
roythearsonist previously approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@roythearsonist roythearsonist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, although I have no idea how exactly this would work

Thomas-Boi
Thomas-Boi requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great. Just need to fix a few sentences and we are good

.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/icon_request.yml Outdated Show resolved Hide resolved
@Panquesito7 @Thomas-Boi
Apply suggestions from code review
de96e30 
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Thomas-Boi
Thomas-Boi approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can't wait to see it in action soon 👍

@Thomas-Boi Thomas-Boi merged commit 0466371 into develop Jul 21, 2021
@Panquesito7 Panquesito7 deleted the panquesito7/feature/convert_to_issue_forms branch July 21, 2021 21:28
@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

@roythearsonist roythearsonist roythearsonist left review comments

@amacado amacado Awaiting requested review from amacado

Assignees

@Panquesito7 Panquesito7

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panquesito7 @Thomas-Boi @roythearsonist