Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: clojurescript (plain) #795

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Conversation

Thomas-Boi
Copy link
Member

Update the clojurescript-plain icon as seen in #788. You can also view the new peek-bot's report on this icon here.

@Thomas-Boi Thomas-Boi added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 10, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@roythearsonist
Copy link
Contributor

I thought all svgs had to be on one line

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Thomas-Boi
Copy link
Member Author

I thought all svgs had to be on one line

We have a bot that optimizes the SVGs for us for every release. However, it's quite new so sometimes, we ask people to optimize the files themselves.

From now on, contributors don't have to optimize the SVG files any more

@Panquesito7 Panquesito7 merged commit 0053ce0 into develop Aug 11, 2021
@Thomas-Boi Thomas-Boi deleted the thomas/icons/clojurescript branch August 12, 2021 22:32
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants