-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: storybook (original, original-wordmark, plain, plain-wordmark) #799
new icon: storybook (original, original-wordmark, plain, plain-wordmark) #799
Conversation
…018/devicon into jonlima/icons/storybook
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the S
transparent instead of solid white in all icons.
This comment has been minimized.
This comment has been minimized.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @jonlima2018! Thank you for your contribution! 😄👍🎉
Hi @jonlima2018, The icons look great! Thank you for your work. Unfortunately, we won't be accepting icons PR until the next release. This is because we are upgrading our Please wait until the release comes out. Once that's out, we will look at this PR again and hopefully merge it. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: You can click on the pictures and zoom on them if needed. The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons look good! Thank you @jonlima2018 and welcome to the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @jonlima2018! You did great to be your first contribution here! Congratulations, and thank you! We hope you keep contributing. 😄👍🎉
…rk) (devicons#799) * feat: added storybook icons * feat: updated devicon.json * fix: updated devicon.json without auto formatter * fix: updated devicon.json without auto formatter * correct file with storybook * Fix the `devicon.json` file * Update icons/storybook/storybook-original-wordmark.svg * Update icons/storybook/storybook-plain-wordmark.svg * Update icons/storybook/storybook-original.svg * Apply suggestions from code review * feat: all icons with the S transparent Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
issue #266