Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: unrealengine (original, original-wordmark) #843

Closed
wants to merge 2 commits into from

Conversation

Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Sep 9, 2021

New icon section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Sep 9, 2021
@Panquesito7 Panquesito7 linked an issue Sep 9, 2021 that may be closed by this pull request
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Sep 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Panquesito7
Copy link
Member Author

👀 not sure why it is showing up like that. I opened the SVGs in my browser, and both of them are looking fine.

@Thomas-Boi
Copy link
Member

It's due to the clip-paths:
image

Removing them will cause the issues that we see.
image

Is there a way for you to make the SVGs to not have clip-paths?

@Panquesito7
Copy link
Member Author

It's due to the clip-paths:
image

Removing them will cause the issues that we see.
image

Is there a way for you to make the SVGs to not have clip-paths?

Hmm, not sure how to fix that...
Any ideas for that? 🤔

@Thomas-Boi
Copy link
Member

Where did you get these SVGs? Did you create them yourselves or was it from a website?

@Panquesito7
Copy link
Member Author

Where did you get these SVGs? Did you create them yourselves or was it from a website?

I took them from Wikipedia and slightly edited them. I thought that would be fine. 🤷‍♂️

@Thomas-Boi
Copy link
Member

Perhaps try finding a different one? Or searching online on how to convert clip-path to paths or a different object.

@Thomas-Boi
Copy link
Member

Hey @Panquesito7, are you still working on this? If not, I'll close this PR so someone else can do this icon.

@Panquesito7
Copy link
Member Author

Hey @Panquesito7, are you still working on this? If not, I'll close this PR so someone else can do this icon.

Sure, feel free to close it,

@Thomas-Boi Thomas-Boi closed this Oct 22, 2021
@Thomas-Boi Thomas-Boi deleted the panquesito7/new_icon/unreal_engine branch December 22, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Unreal Engine
2 participants