Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: opencv (original, original-wordmark, plain, plain-wordmark) #875

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 9, 2021

New icon section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • The PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date

https://opencv.org/resources/media-kit/

This PR adds/fixes

Notes

Can you please add the label 'hacktoberfest-accepted' to this PR. I plan to contribute some more icons, to fulfill (at least) the 4 required Pullrequests.

https://hacktoberfest.digitalocean.com/faq

Any pull request with the hacktoberfest-accepted label, submitted to any public GitHub/GitLab repository, with or without the hacktoberfest topic, will be considered valid for Hacktoberfest.

@roythearsonist
Copy link
Contributor

Edit the title and initial comment and describe your changes.

@Panquesito7 Panquesito7 changed the title new icon (original, original-wordmark, plain, plain-wordmark) new icon: opencv (original, original-wordmark, plain, plain-wordmark) Oct 10, 2021
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 10, 2021
weh and others added 2 commits October 10, 2021 14:36
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 10, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

@amacado amacado merged commit 9c410f0 into devicons:develop Oct 10, 2021
@Thomas-Boi Thomas-Boi mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants