refactor(Video): Do not print "?"/"Unknown" values in str()

devine-dl · Apr 14, 2024 · 9ddd9ad · 9ddd9ad
1 parent dae83b0
commit 9ddd9ad
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/devine/core/tracks/video.py b/devine/core/tracks/video.py
@@ -165,12 +165,20 @@ def __init__(self, *args: Any, codec: Video.Codec, range_: Video.Range, bitrate:
         self.fps = FPS.parse(str(fps)) if fps else None
 
     def __str__(self) -> str:
-        fps = f"{self.fps:.3f}" if self.fps else "Unknown"
         return " | ".join(filter(bool, [
             "VID",
-            f"[{self.codec.value}, {self.range.name}]",
+            "[" + (", ".join(filter(bool, [
+                self.codec.value if self.codec else None,
+                self.range.name
+            ]))) + "]",
             str(self.language),
-            f"{self.width}x{self.height} @ {self.bitrate // 1000 if self.bitrate else '?'} kb/s, {fps} FPS",
+            ", ".join(filter(bool, [
+                " @ ".join(filter(bool, [
+                    f"{self.width}x{self.height}" if self.width and self.height else None,
+                    f"{self.bitrate // 1000} kb/s" if self.bitrate else None
+                ])),
+                f"{self.fps:.3f} FPS" if self.fps else None
+            ])),
             self.edition
         ]))