Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dl): delete old file after repackage #114

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(dl): delete old file after repackage #114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e33ea
fix(dl): delete old file after repackage
retouching May 27, 2024
0542e89
fix(dl): using original_path instead of self.path in repackage method
retouching Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions devine/core/tracks/track.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ def _ffmpeg(extra_args: list[str] = None):
else:
raise

self.path.unlink()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it original_path.unlink() instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course 👍 0542e89

self.path = output_path


Expand Down
Loading