Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events not working as expected #95

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Events not working as expected #95

merged 2 commits into from
Apr 5, 2024

Conversation

knowhere01
Copy link
Contributor

@knowhere01 knowhere01 commented Apr 5, 2024

Events is not working as expected as self.__subscriptions and self.__ephemeral are pointing to the same object.

Even though, it is separated when initialize but this line that calls reset and make both variable pointing to the same object which make this line clear both self.__subscriptions and self.__ephemeral.

I believe this is not intended behavior cause it make only some of the tracks (in my case 2 tracks) got passed into on_xxx in service class.

@knowhere01 knowhere01 deleted the branch devine-dl:master April 5, 2024 11:09
@knowhere01 knowhere01 closed this Apr 5, 2024
@knowhere01 knowhere01 deleted the master branch April 5, 2024 11:09
@knowhere01 knowhere01 restored the master branch April 5, 2024 11:12
@knowhere01
Copy link
Contributor Author

Sorry for the messy history, it's my first PR :p

@knowhere01 knowhere01 reopened this Apr 5, 2024
@rlaphoenix
Copy link
Member

rlaphoenix commented Apr 5, 2024

Hi, I don't see the issue. The current code should work as expected and your commit wouldn't make a difference here. My bad, I see the problem. I just woke up lol.

@rlaphoenix rlaphoenix merged commit b7ea94d into devine-dl:master Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants