Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting highest quality audio track for each language when "best" is specified #98

Closed
wants to merge 0 commits into from

Conversation

Sp5rky
Copy link

@Sp5rky Sp5rky commented Apr 13, 2024

  • The modified code checks if "all" is present in the lang list.
  • If "all" is found, it retrieves a set of unique languages from the available audio tracks.
  • For each unique language, it iterates through the audio tracks and finds the track with the highest bitrate.
  • It then adds the highest quality track for each language to the selected_audio list.
  • Finally, it sets the title.tracks.audio to the selected_audio list, containing the highest quality track for each language.
  • If "all" is not found in the lang list, the existing behavior for specific language selection is maintained.

Fixes #93

@Sp5rky Sp5rky changed the title ✨ (dl.py): Add support for selecting highest quality audio track for each language when "all" is specified Add support for selecting highest quality audio track for each language when "all" is specified Apr 13, 2024
@Sp5rky
Copy link
Author

Sp5rky commented Apr 16, 2024

Changed naming of -l all to -l best as I feel its easier to understand

@Sp5rky Sp5rky changed the title Add support for selecting highest quality audio track for each language when "all" is specified Add support for selecting highest quality audio track for each language when "best" is specified Apr 17, 2024
@Sp5rky Sp5rky closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-l all flag should probably take all lang instead of take all tracks
1 participant