Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence mypy's PEP561 warning #43

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

sr0lle
Copy link
Contributor

@sr0lle sr0lle commented Dec 18, 2023

Hey, this PR silences mypy's PEP561 warning. The py.typed file tells mypy that the library uses type annotations, see PEP561 and the mypy docs. Poetry includes the file automatically.

@rlaphoenix
Copy link
Member

rlaphoenix commented Dec 22, 2023

I don't see why this package needs this file. I don't personally get PEP561 warnings on my end at least, and it seems like this file is used more often for type-shed style packages, e.g. types-requests (PEP484 stubs). Am I wrong? Are you getting a warning from mypy when linting your project that uses pywidevine, or is it when linting this one exclusively?

I do see some other projects using py.typed though, so I'll just take your word for it honestly.

@rlaphoenix rlaphoenix merged commit 6faad19 into devine-dl:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants