-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: fix cse with different conditionals #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2410 +/- ##
=======================================
Coverage 86.74% 86.75%
=======================================
Files 235 235
Lines 44563 44610 +47
Branches 8250 8257 +7
=======================================
+ Hits 38657 38702 +45
- Misses 5187 5189 +2
Partials 719 719 ☔ View full report in Codecov by Sentry. |
99fb87e
to
fc6ee5c
Compare
EdCaunt
reviewed
Jul 16, 2024
65d7d69
to
46b15c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cse to make sure expression from different conditionals get properly handled.
avoids things like
to be converted to
CSE now counts expression based on the equation's conditional. We could also just lift all
rxx
out of conditionals but that would be computing those cse temps way more than needed which I don't think it great