Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 IsDirty is a string #243

Closed
PA4WD opened this issue Feb 20, 2023 · 2 comments · Fixed by #249
Closed

V3 IsDirty is a string #243

PA4WD opened this issue Feb 20, 2023 · 2 comments · Fixed by #249
Assignees
Labels

Comments

@PA4WD
Copy link

PA4WD commented Feb 20, 2023

Describe the Bug

In a C# blazor project using ThisAssembly.Git.IsDirty.
After updating to v3
I get the error CS0029 Cannot implicitly convert type 'string' to 'bool'

GitInfo_bug

ThisAssembly.Git.IsDirtyString is also empty

Steps to Reproduce

use IsDirty as a bool

Version Info

V3.0.2

Additional Info

@PA4WD PA4WD added the bug label Feb 20, 2023
@kzu
Copy link
Member

kzu commented Feb 21, 2023

dang, yeah, this is a bug due to a missing feature in ThisAssembly.Constants

@kzu kzu self-assigned this Feb 21, 2023
@kzu
Copy link
Member

kzu commented Feb 22, 2023

For now, you can workaround the issue by changing your code to:

if (bool.TryParse(ThisAssembly.Git.IsDirtyString, out var isDirty) && isDirty)
{
}

kzu added a commit that referenced this issue Feb 22, 2023
With the change to ThisAssembly.Constants, we introduced a bug that caused IsDirty to be a string contant, instead of the boolean it was up to 2.3.

Closes #243
kzu added a commit that referenced this issue Feb 22, 2023
With the change to ThisAssembly.Constants, we introduced a bug that caused IsDirty to be a string contant, instead of the boolean it was up to 2.3.

Closes #243
@kzu kzu closed this as completed in #249 Feb 22, 2023
kzu added a commit that referenced this issue Feb 22, 2023
With the change to ThisAssembly.Constants, we introduced a bug that caused IsDirty to be a string contant, instead of the boolean it was up to 2.3.

Closes #243
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants