Fix race conditions #330
Merged
Fix race conditions #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target conditions and git info cache sufficient for incremental build.
Continue on error as eventually successful.
Continue on error as eventually successful.
Continue on error as same as no cache.
|
|
|
@kzu PTAL; I've done a fair bit of local testing and would love to get this approved, merged and released. 🙏 |
|
I like how you changed properties with file reading to items via read lines 👌. The non -central location for the cache has to do with submodules and projects in the same solution coming from them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321.