Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant depends on targets #346

Merged
merged 1 commit into from
May 30, 2024
Merged

Remove redundant depends on targets #346

merged 1 commit into from
May 30, 2024

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 27, 2024

Reduces build log noise by removing redundant "depends on" targets. Leverages known transitive target dependencies as follows:

  • GitThisAssembly -> GitVersion
  • GitVersion -> GitInfo

Removes GitThisAssemblyDependsOn property to use simplified inline DependsOnTargets attribute.
Changes CoreCompileDependsOn modifications to conditionally inject GitThisAssembly target.

@kzu
Copy link
Member

kzu commented May 30, 2024

Removal of GitThisAssemblyDependsOn could be a breaking change, but since nobody is using it, I'm fine taking that too: https://github.com/search?q=%24%28GitThisAssemblyDependsOn%29&type=code

@kzu kzu merged commit 8c8cbed into devlooped:main May 30, 2024
5 checks passed
@gitfool gitfool deleted the fix-depends branch May 30, 2024 03:22
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitfool @kzu