Set activity status to error when an exception is recorded

Fixes #77
devlooped · Nov 19, 2022 · d4c6e5d · d4c6e5d
1 parent 3e526e6
commit d4c6e5d
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/src/Merq.Core/Telemetry.cs b/src/Merq.Core/Telemetry.cs
@@ -22,12 +22,17 @@ static class Telemetry
 
     public static void RecordException(this Activity? activity, Exception e)
     {
-        // See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/exceptions.md
-        activity?.AddEvent(new ActivityEvent("exception", tags: new()
+        if (activity != null)
         {
-            { "exception.message", e.Message },
-            { "exception.type", e.GetType().FullName },
-            { "exception.stacktrace", e.ToString() },
-        }));
+            activity.SetStatus(ActivityStatusCode.Error, e.Message);
+
+            // See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/exceptions.md
+            activity.AddEvent(new ActivityEvent("exception", tags: new()
+            {
+                { "exception.message", e.Message },
+                { "exception.type", e.GetType().FullName },
+                { "exception.stacktrace", e.ToString() },
+            }));
+        }
     }
 }