Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue a warning for non-public commands #71

Closed
kzu opened this issue Nov 18, 2022 · 0 comments · Fixed by #72
Closed

Issue a warning for non-public commands #71

kzu opened this issue Nov 18, 2022 · 0 comments · Fixed by #72
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Nov 18, 2022

Public commands types can use the C# dynamic dispatch which performs better than plain reflection.

We should warn users in that situation, to consider making their commands public.
@kzu kzu added the enhancement New feature or request label Nov 18, 2022
kzu added a commit that referenced this issue Nov 18, 2022
@kzu
Issue a warning for non-public commands
c790c85 
Public commands types can use the C# dynamic dispatch which performs better than plain reflection, so issue a warning if they are not.

Closes #71
@kzu kzu mentioned this issue Nov 18, 2022
Merged
@kzu kzu closed this as completed in #72 Nov 18, 2022
kzu added a commit that referenced this issue Nov 18, 2022
@kzu
Issue a warning for non-public commands
0e082f6 
Public commands types can use the C# dynamic dispatch which performs better than plain reflection, so issue a warning if they are not.

Closes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue a warning for non-public commands devlooped/Merq
1 participant
@kzu