Duck typing of events and commands #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
feature/ducktyping
branch
from
8673b2e
to
bfc5525
Compare
A new records-based generator emits an __[Type]Factory that can convert from dynamic to the target record type. Observe now adds another Subject that can convert, and we register this subject as compatible whenever the target type doesn't equal the given event. We optimize this scenario by caching these new compatible subjects like we did before. If no converter is available, the event type will just never be invoked in this "duck typing" manner. We offer two conversion mechanisms: the generated factory, and an explicitly declared `Create(dynamic)` method on the record type. This can allow more complex scenarios to still work even if we don't generate code for them. Closes #31
We do not perform conversion on return types (yet). Closes #33
kzu
force-pushed
the
feature/ducktyping
branch
from
bfc5525
to
bdd905e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic support including: