Support sync/async execute fixer on returning commands too #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not consider those as candidates for the fix.
Implementing command handlers is a bit tricky when the command returns a value, since you need to specify both the command type and its return type in the ICommandHandler<T, TResult> declaration. Changes in the command definition (adding a return type or changing it) result in hard to read compiler errors which can be discouraging. The new analyzer will detect these situations: - Missing return type for a non-void command - Mismatched return type And we offer code fixers that fix both scenarios, including rewriting the Execute method to have the correct return type. Closes #37
kzu
force-pushed
the
feature/handlerfixer
branch
from
ea799f0
to
103fa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not consider those as candidates for the fix.