Add comprehensive tests for analyzers and code fixes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which immediately uncovered a bug and got it fixed :)
Tests that ensure we apply all fixers we support for handlers.
Using the basic library works well enough already.
The compiler (for now? always?) assumes that an invocation to ExecuteAsync<T> is always the IMessageBus method receiving a TResult and requiring a command argument. It's impossible to have it pick the parameterless extension method, or even one requiring the CancellationToken whether this parameter allows a default or not.
The Execute<TCommand> shorthand notation cannot be used with async commands, so the fix should also turn the `TCommand` generic parameter into `new TCommand()` argument for `ExecuteAsync`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.