Add support for hierarchical record creation from generated factories #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now invoke factories automatically whenever they are found. A new diagnostic is reported if a `Create(dynamic value)` factory method is found in the record but it's not accessible to the generated factory in the current assembly. The diagnostic is nevertheless a warning since in that case we still generate our custom factory, but users will not get the benefit of invoking their custom factory (although this might be by design if it's just a coincidence in the method name and signature they chose for an entirely unrelated purpose). Closes #47
kzu
force-pushed
the
dev/dynamic-hierarchy
branch
from
25e8d5d
to
09a45e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now invoke factories automatically whenever they are found.
A new diagnostic is reported if a
Create(dynamic value)factory method is found in the record but it's not accessible to the generated factory in the current assembly. The diagnostic is nevertheless a warning since in that case we still generate our custom factory, but users will not get the benefit of invoking their custom factory (although this might be by design if it's just a coincidence in the method name and signature they chose for an entirely unrelated purpose).Closes #47