Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from TableEntity to ITableEntity in the non-generic repository for flexibility #48

Closed
kzu opened this issue Jul 1, 2021 · 0 comments · Fixed by #49
Closed

Switch from TableEntity to ITableEntity in the non-generic repository for flexibility #48

kzu opened this issue Jul 1, 2021 · 0 comments · Fixed by #49
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Jul 1, 2021 •
edited by devlooped-bot
Loading

We currently use TableEntity for out TableEntityRepository. This limits the scenarios where you can use this repository, since it would not allow reading additional properties that may exist in the table, and also would not allow entity merging behavior like #46 introduced.

By switching the public API to ITableEntity, we would remain API-compatible with the previous version, but using DynamicTableEntity implementation internally would allow saving/merging additional properties as needed.

Back this issue
Back this issue
@kzu kzu added the enhancement New feature or request label Jul 1, 2021
@kzu kzu changed the title Switch from TableEntity to DynamicTableEntity in the non-generic repository for flexibility Switch from TableEntity to ITableEntity in the non-generic repository for flexibility Jul 1, 2021
kzu added a commit that referenced this issue Jul 1, 2021
@kzu
Allow additional properties in table entity repository
ceabfa7 
By switching the public API to ITableEntity, we remain API-compatible with the previous version, but using DynamicTableEntity implementation internally allows saving/merging additional properties as needed.

The caller would need to downcast to `DynamicTableEntity` still, but the scenario woiuld be enabled.

Fixes #48
@kzu kzu mentioned this issue Jul 1, 2021
Merged
@kzu kzu closed this as completed in #49 Jul 1, 2021
kzu added a commit that referenced this issue Jul 1, 2021
@kzu
Allow additional properties in table entity repository
eaecb13 
By switching the public API to ITableEntity, we remain API-compatible with the previous version, but using DynamicTableEntity implementation internally allows saving/merging additional properties as needed.

The caller would need to downcast to `DynamicTableEntity` still, but the scenario woiuld be enabled.

Fixes #48
@devlooped devlooped locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow additional properties in table entity repository devlooped/TableStorage
1 participant
@kzu