Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enhanced filtering for document-based repo #38

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

kzu
Copy link
Member

@kzu kzu commented Jun 16, 2021

We now need a new document-based specific interface since it will have a new method (EnumerateAsync) which is exclusive for documents. So we rename the old interfaces to ITableStorage and ITableStoragePartition, which now become the base interfaces for both, and introduce the new IDocumentRepository and IDocumentPartition which basically add the new enumeration with a filtering expression.

The implementation for documents relies on the underlying TableQuery, since we are persisting actual TableEntity objects and therefore don't need any of the shenanigans from our POCO repos.

Fixes #37

We now need a new document-based specific interface since it will have a new method (EnumerateAsync) which is exclusive for documents. So we rename the old interfaces to `ITableStorage` and `ITableStoragePartition`, which now become the base interfaces for both, and introduce the new `IDocumentRepository` and `IDocumentPartition` which basically add the new enumeration with a filtering expression.

The implementation for documents relies on the underlying `TableQuery`, since we are persisting actual `TableEntity` objects and therefore don't need any of the shenanigans from our POCO repos.

Fixes #37
@kzu kzu enabled auto-merge (rebase) June 16, 2021 21:15
@kzu kzu merged commit 5d36c5e into main Jun 16, 2021
@kzu kzu deleted the dev branch June 16, 2021 21:18
@devlooped devlooped locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enhanced filtering for document-based repositories
1 participant