Fix test filter for theory tests #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzu
force-pushed
the
dev/fix-retry
branch
4 times, most recently
from
1c260c4 to
fa7ffaf
Compare
# devlooped/oss - Fix test filter for theory tests devlooped/oss@1725809 - Update action.yml devlooped/oss@fca55bc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theories contain additional characters in the test display name,
including whitespaces and a rendering of the data elements for each
test, such as
Devlooped.DocumentRepositoryTests.DocumentEndToEnd(serializer: DocumentSerializer { }).The existing regex would truncate the string at the whitespace,
resulting in
Devlooped.DocumentRepositoryTests.DocumentEndToEnd(serializer:which then wouldn't match any tests, making it appear that the test
run was otherwise successful.
This fixes that by switching to test full name. Also adds workarounds for
a few remaining test failures on CI.