Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If resource name contains an invalid identifier character, replace it with underscore #125

Closed
kzu opened this issue Oct 15, 2022 · 0 comments · Fixed by #126
Closed

If resource name contains an invalid identifier character, replace it with underscore #125

kzu opened this issue Oct 15, 2022 · 0 comments · Fixed by #126
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Oct 15, 2022 •
edited
Loading

So that "Foo:Bar" is valid and turned into "Foo_Bar".

Built-in resource generator supports the following characters, which all turn to underscores: |, :, ;, >, <.

Add more as needed, but at a minimum, those should be added for parity.
kzu added a commit that referenced this issue Oct 15, 2022
@kzu
Improve support for invalid identifier characters
5f7d9b9 
This brings parity with the built-in resource generator, which properly
converts |, :, ;, < and > to underscores in the generated member
names.

Fixes #125
@kzu kzu mentioned this issue Oct 15, 2022
Merged
kzu added a commit that referenced this issue Oct 15, 2022
@kzu
Improve support for invalid identifier characters
4453b07 
This brings parity with the built-in resource generator, which properly
converts |, :, ;, < and > to underscores in the generated member
names.

Fixes #125
@kzu kzu closed this as completed in #126 Oct 15, 2022
kzu added a commit that referenced this issue Oct 15, 2022
@kzu
Improve support for invalid identifier characters
668990f 
This brings parity with the built-in resource generator, which properly
converts |, :, ;, < and > to underscores in the generated member
names.

Fixes #125
@kzu kzu added the enhancement New feature or request label Oct 18, 2022
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve support for invalid identifier characters devlooped/ThisAssembly
1 participant
@kzu