Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails for assembly metadata containing . #247

Closed
Khitiara opened this issue Jul 8, 2023 · 3 comments · Fixed by #312
Closed

Fails for assembly metadata containing . #247

Khitiara opened this issue Jul 8, 2023 · 3 comments · Fixed by #312
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Khitiara
Copy link

Khitiara commented Jul 8, 2023

Describe the Bug

AssemblyMetadata attributes whose keys include the . characte those generate into invalid constant names and produce compiler errors.

Steps to Reproduce

[assembly: System.Reflection.AssemblyMetadata("A.B", "")]
[assembly: System.Reflection.AssemblyMetadata("A.C", "")]

Expected Behavior

Compilation to succeed.

Version Info

ThisAssembly 1.3.1

Additional Info

Discovered when using Verify which generates a few such metadata attributes during build
@Khitiara Khitiara added the bug Something isn't working label Jul 8, 2023
@kzu kzu added the good first issue Good for newcomers label Aug 8, 2023
@kzu
Copy link
Member

kzu commented Aug 8, 2023

Consider sponsoring @devlooped to bump the priority of this.

Otherwise, we'd gladly take a PR!

@dmirmilshteyn
Copy link

This problem also causes a failure when you include the sentry.io SDK, since that adds a Senry.ProjectDirectory AssemblyMetadata attribute.

@kzu
Copy link
Member

kzu commented Sep 27, 2023

Happy to take a PR 👌

kzu added a commit that referenced this issue Jun 9, 2024
@kzu
Simplify and redesign ThisAssembly.Metadata as a special case of Cons…
11dc21e 
…tants

This allows us to support Comment attribute, but more importantly, support hierarchical metadata ids to generate the nested class structure like we have in Constants.

Fixes #247
kzu added a commit that referenced this issue Jun 9, 2024
@kzu
Simplify and redesign ThisAssembly.Metadata as a special case of Cons…
8465ba4 
…tants

This allows us to support Comment attribute, but more importantly, support hierarchical metadata ids to generate the nested class structure like we have in Constants.

Fixes #247
@kzu kzu mentioned this issue Jun 9, 2024
Merged
@kzu kzu closed this as completed in #312 Jun 9, 2024
@kzu kzu closed this as completed in 2442c61 Jun 9, 2024
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify and redesign ThisAssembly.Metadata as a special case of Constants devlooped/ThisAssembly
3 participants
@kzu @Khitiara @dmirmilshteyn