Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed Scriban for reduced size and improved isolation #39

Closed
kzu opened this issue Jan 25, 2021 · 0 comments
Closed

Embed Scriban for reduced size and improved isolation #39

kzu opened this issue Jan 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Jan 25, 2021

For cases where more than one analyzer is using Scriban for source generators, we might get conflicts and generation might fail if they use a different version than our generators.

Luckily, scriban now supports source embedding so we can eliminate that risk by leveraging that feature.
@kzu kzu added the enhancement New feature or request label Jan 25, 2021
kzu added a commit that referenced this issue Jan 25, 2021
@kzu
📦 Embed Scriban for reduced size and improved isolation
ba838ee 
For cases where more than one analyzer is using Scriban for source generators, we might get conflicts and generation might fail if they use a different version than our generators.

Luckily, scriban now supports source embedding so we can eliminate that risk by leveraging that feature.

Fixes #39
kzu added a commit that referenced this issue Jan 25, 2021
@kzu
📦 Embed Scriban for reduced size and improved isolation
69a6767 
For cases where more than one analyzer is using Scriban for source generators, we might get conflicts and generation might fail if they use a different version than our generators.

Luckily, scriban now supports source embedding so we can eliminate that risk by leveraging that feature.

Fixes #39
@kzu kzu closed this as completed in 9d53dae Jan 25, 2021
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu