Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThisAssembly.Prerequisites fails with VS 16.10 preview #50

Closed
kzu opened this issue Mar 8, 2021 · 0 comments · Fixed by atifaziz/CSharpSyntaxValidator#16
Closed

ThisAssembly.Prerequisites fails with VS 16.10 preview #50

kzu opened this issue Mar 8, 2021 · 0 comments · Fixed by atifaziz/CSharpSyntaxValidator#16
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented Mar 8, 2021

The build always fails with ThisAssembly requires MSBuild 16.8+ or .NET SDK 5.0+..

This seems to be because the comparison of MSBuild short version (i.e. 16.8 vs 16.10) is
not done numerically, but as a string, resulting in 16.10 being smaller than 16.8. This
didn't surface before because 16.9 is lexicographically greater than 16.8, but now that's
no longer the case.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ThisAssemply.AssemblyInfo to 1.0.8 atifaziz/CSharpSyntaxValidator
1 participant
@kzu