-
-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix version comparison and use built-in property
The existing code would always fail the comparison becuase it was not done numerically, but as a string, resulting in 16.10 being smaller than 16.8. We fix it by parsing the full `MSBuildVersion` as a vesion instead, and comparing it to the minimum version (16.8) also parsed as a `Version` object. Fixes #50
- Loading branch information
Showing
2 changed files
with
3 additions
and
5 deletions.
There are no files selected for viewing
4 changes: 0 additions & 4 deletions
4
src/ThisAssembly.Prerequisites/ThisAssembly.Prerequisites.props
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
src/ThisAssembly.Prerequisites/ThisAssembly.Prerequisites.targets
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters