Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThisAssembly.Git, leveraging Microsoft.SourceLink and ThisAssembly.Constants #169

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

kzu
Copy link
Member

@kzu kzu commented Jan 25, 2023

This new package is just targets that leverage git-based SourceLink packages (which must be installed separately since there is a variety) to populate source control information, turn it into constants that then the ThisAssembly.Constants package surfaces in a standard manner.

We do not force run of source control queries in design-time builds, unless the user forces it. This keeps the performance characteristics of SourceLink, at the expense of a slightly confusing user experience where intellisense might show the properties as empty all the time while in fact it's just during design-time.

Closes #69

@kzu kzu added the enhancement New feature or request label Jan 25, 2023
…y.Constants

This new package is just targets that leverage git-based SourceLink
packages (which must be installed separately since there is a variety)
to populate source control information, turn it into constants that then
the ThisAssembly.Constants package surfaces in a standard manner.

We do not force run of source control queries in design-time builds,
unless the user forces it. This keeps the performance characteristics
of SourceLink, at the expense of a slightly confusing user experience
where intellisense might show the properties as empty all the time
while in fact it's just during design-time.

Closes #69
@kzu kzu enabled auto-merge (rebase) January 25, 2023 06:13
@kzu kzu merged commit f495697 into main Jan 25, 2023
@kzu kzu deleted the dev/git branch January 25, 2023 06:16
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ThisAssembly.Git
1 participant