Specify comparer when search resource name #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@atifaziz if you could sign the CLA, I can merge this! |
Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line causes CA1310 to be flagged in a user project with code analysis enabled:
ThisAssembly/src/EmbeddedResource.cs
Line 38 in 65f0469
It can fail the compilation of the host project if warnings are being treated as errors.
This PR updates the call to specify a comparer explicitly. The choice of
StringComparison.Ordinalshould be in line withAssembly.GetManifestResourceStreamwhose documentation states thatnameis “The case-sensitive name of the manifest resource being requested.”