After grace period, emit code with warnings #383
Conversation
kzu
force-pushed
the
dev/obsoleterun
branch
from
fae8f07 to
1b63973
Compare
|
🧪 Details on macOS Unix 14.6.1✅ ThisAssemblyTests.ScribanTests.CanRenderModel 🧪 Details on Ubuntu 22.04.4 LTS✅ ThisAssemblyTests.ScribanTests.CanRenderModel 🧪 Details on Microsoft Windows 10.0.20348✅ ThisAssemblyTests.ScribanTests.CanRenderModel from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜 |
kzu
force-pushed
the
dev/obsoleterun
branch
2 times, most recently
from
b0a5220 to
d4ccfb8
Compare
It was made quite clear that (some?) folks would rather just disable our friendly warning rather than sponsor. So we'll instead just make sponsorship mandatory. See #352 (comment) I worked hard to accomodate very flexible options for sponsoring, and this project ain't maintaining itself. It's fine if folks use something else. I made this initially just for myself, and I'm glad it's been useful for others. We also add remarks to the emitted APIs during the grace period, so it's not surprising they turn to warnings later.
kzu
force-pushed
the
dev/obsoleterun
branch
from
d4ccfb8 to
a5337d8
Compare
It was made quite clear that (some?) folks would rather just disable our friendly warning rather than sponsor. So we'll instead just make sponsorship mandatory.
See #352 (comment)
I worked hard to accomodate very flexible options for sponsoring, and this project ain't maintaining itself. It's fine if folks use something else. I made this initially just for myself, and I'm glad it's been useful for others.
TODO: pending updating AssemblyInfo and Strings to use the same approach (those don't leverage Constants like the others).