Add support for ThisAssemblyVisibility for public and static readonly constants #400
Conversation
|
🧪 Details on Microsoft Windows 10.0.20348✅ ThisAssemblyTests.ScribanTests.CanRenderModel from dotnet-retest v0.6.3 on .NET 8.0.8 with 💜 |
Setting the `ThisAssembly` class to public should be somewhat rare, but might be desirable in some cases. When the class is made public, there's a surprising "bug" in that updating the assembly providing the `ThisAssembly` class will *not* cause another assembly consuming its values to reflect the changes. This is because the compiler will efectively inline the constants, so effectively every call site has a copy of the value. This is somewhat unintuitive, but it's perfectly sensible when the use is for internal purposes. The new ThisAssemblyVisibility=public property allows both setting the generated class visibility to public and switching (for constants) to static properties. For ThisAssembly.Strings and ThisAssembly.Resources, only the class visibility is changed. Fixes #64
kzu
changed the title
Setting the
ThisAssemblyclass to public should be somewhat rare, but might be desirable in some cases. When the class is made public, there's a surprising "bug" in that updating the assembly providing theThisAssemblyclass will not cause another assembly consuming its values to reflect the changes. This is because the compiler will efectively inline the constants, so effectively every call site has a copy of the value.This is somewhat unintuitive, but it's perfectly sensible when the use is for internal purposes.
The new ThisAssemblyVisibility=public property allows both setting the generated class visibility to and switching (for constants) to static properties.
For ThisAssembly.Strings and ThisAssembly.Resources, only the class visibility is changed.
Fixes #64