More consistent callback parameter list formatting

devlooped · Aug 7, 2019 · 6ed6078 · 6ed6078
1 parent 70030c0
commit 6ed6078
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Moq/MethodCall.cs b/src/Moq/MethodCall.cs
@@ -13,6 +13,8 @@
 
 using Moq.Properties;
 
+using TypeNameFormatter;
+
 namespace Moq
 {
 	internal sealed partial class MethodCall : SetupWithOutParameterSupport
@@ -185,13 +187,14 @@ public void SetCallbackResponse(Delegate callback)
 				var expectedParamTypes = this.Method.GetParameterTypes();
 				if (!callback.CompareParameterTypesTo(expectedParamTypes))
 				{
+					// TODO: the following won't properly distinguish between `in`, `ref`, and `out` parameters!
 					var actualParams = callback.GetMethodInfo().GetParameters();
 					throw new ArgumentException(
 						string.Format(
 							CultureInfo.CurrentCulture,
 							Resources.InvalidCallbackParameterMismatch,
-							string.Join(",", expectedParamTypes.Select(p => p.Name).ToArray()),
-							string.Join(",", actualParams.Select(p => p.ParameterType.Name).ToArray())));
+							string.Join(", ", expectedParamTypes.Select(p => p.GetFormattedName()).ToArray()),
+							string.Join(", ", actualParams.Select(p => p.ParameterType.GetFormattedName()).ToArray())));
 				}
 
 				if (callback.GetMethodInfo().ReturnType != typeof(void))