Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard 2.1 #1041

Closed
twsl opened this issue Jul 27, 2020 · 4 comments · Fixed by #1042
Closed

Add .NET Standard 2.1 #1041

twsl opened this issue Jul 27, 2020 · 4 comments · Fixed by #1042

Comments

@twsl
Copy link
Contributor

twsl commented Jul 27, 2020

Since .NET Core 3.1 is an LTS version, support for .NET Standard 2.1 should definitly be added.

@stakx
Copy link
Contributor

stakx commented Jul 27, 2020

Yes @twsl, you're right.

Please note that as of now, our main dependency DynamicProxy still only has .NET Standard 1.x targets, so adding .NET Standard 2.x targets here at Moq won't actually have much benefit... you'll still get an awful lot of .NET Standard 1.x dependencies installed.

I'm actively working on a DynamicProxy release that also has .NET Standard 2.x targets, but there's quite a bit of other work left to do before an updated version can be released.

@twsl
Copy link
Contributor Author

twsl commented Jul 27, 2020

Nice to hear, let me know if you need any help with that.

@twsl
Copy link
Contributor Author

twsl commented Jul 30, 2020

Actually, DynamicProxy already has multi targets, 2.0 and 2.1 to be precise. Which is why a created a pull request to target 2.1 as well

Edit: Oh, my bad, I didn't noticed that a new nuget package has not been pushed for 3 months. If it's ok for you, I'll leave the PR open anyway

@stakx
Copy link
Contributor

stakx commented Jul 30, 2020

Yes, leaving the PR open is fine. I won't merge it right away as some bug fixes have to go in first that will end up with a patch-version release. I'll look at your PR for the next minor version release. (We can add the netstandard2.1 target before Castle.Core does, it won't do much good, but it also won't do any harm.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants