Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitarget .NET Standard 2.1 #1042

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Multitarget .NET Standard 2.1 #1042

merged 2 commits into from
Jan 16, 2021

Conversation

twsl
Copy link
Contributor

@twsl twsl commented Jul 30, 2020

Since v5 is not released as an official nuget package yet I'm pushing this minor update to the v4 repo instead.

Contains:

  • Added netstandard2.1 to TargetFrameworks

Additional:

  • Make unit test language invariant

In order to test my changes I ran the unit tests and noticed a language depending unit test. Instead it is now based on the stack trace which makes this language invariant.

Fixes #1041

I'm not too sure if this minor fix actually requires an entry to the changelog. If you want me to add one, please say so.

@stakx
Copy link
Contributor

stakx commented Oct 11, 2020

@twsl, I'd like to merge this, but it might be better to wait until Castle.Core has a netstandard2.1 target, too. So this could remain open for a while.

But we could fix that language-dependent test now. Would you be willing to submit that second commit as a separate PR and remove it from this one?

@stakx stakx changed the base branch from master to main January 16, 2021 14:14
@stakx stakx merged commit 93bcc21 into devlooped:main Jan 16, 2021
@stakx
Copy link
Contributor

stakx commented Jan 16, 2021

@twsl I've merged this even though there still isn't a DynamicProxy release that will directly support .NET Standard 2.1. Turns out this is still useful in order to implement a workaround for #972.

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .NET Standard 2.1
2 participants