Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Castle.Core 3.2.1 because of Mono #113

Closed
ztone opened this issue Jun 7, 2014 · 5 comments
Closed

Upgrade to Castle.Core 3.2.1 because of Mono #113

ztone opened this issue Jun 7, 2014 · 5 comments

Comments

@ztone
Copy link

ztone commented Jun 7, 2014

There is a fix in Castle.Core castleproject/Core@9f0577f that fixes http://stackoverflow.com/questions/18034341/system-collections-generic-keynotfoundexception-with-mono-but-not-microsofts

git tag --contains 9f0577fc in Castle.Core show that this fix was released first in 3.2.1 but Moq is using 3.2.0. A diff shows that there wasn't to much code change so I'm hoping that an upgrade will not be to painful.

Main reason for asking for this is that we are trying to get ScriptCs test to run on mono and because we are using Moq, this is a huge blocker.

@kzu
Copy link
Member

kzu commented Jun 7, 2014

A PR would be great ;)

/kzu from mobile
On Jun 7, 2014 10:12 AM, "Stone Gislason" notifications@github.com wrote:

There is a fix in Castle.Core castleproject/Core@9f0577f
castleproject/Core@9f0577f
that fixes
http://stackoverflow.com/questions/18034341/system-collections-generic-keynotfoundexception-with-mono-but-not-microsofts

git tag --contains 9f0577fc in Castle.Core show that this fix was
released first in 3.2.1 but Moq is using 3.2.0. A diff shows that there
wasn't to much code change so I'm hoping that an upgrade will not be to
painful.

Main reason for asking for this is that we are trying to get ScriptCs test
to run on mono and because we are using Moq, this is a huge blocker.

Reply to this email directly or view it on GitHub
#113.

@ztone
Copy link
Author

ztone commented Jun 7, 2014

Yeah of course, I will cook sth up 😃

@ztone
Copy link
Author

ztone commented Jun 12, 2014

Update!

Upgrading to Castle.Core v3.2.1 did fix the issue, but unfortunately left another similar issue unresolved. So List DoSomething() was fixed, but not T DoSomething().

This needs to be fixed in Castle before pulling in a PR here. Don't know if you want to keep this open until then.

@kzu
Copy link
Member

kzu commented Jun 12, 2014

sure, no prob

/kzu

On Thu, Jun 12, 2014 at 10:49 AM, Stone Gislason notifications@github.com
wrote:

Update!

Upgrading to Castle.Core v3.2.1 did fix the issue, but unfortunately left
another similar issue unresolved. So List DoSomething() was fixed,
but not T DoSomething().

This needs to be fixed in Castle before pulling in a PR here. Don't know
if you want to keep this open until then.

Reply to this email directly or view it on GitHub
#113 (comment).

@kzu
Copy link
Member

kzu commented Feb 21, 2017

plz reopen if this still fails. we've bumped to Castle.Core 4.0 now

@kzu kzu closed this as completed Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants