Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart has broken link to Microsoft Connect #159

Closed
breyed opened this issue Mar 4, 2015 · 8 comments
Closed

Quickstart has broken link to Microsoft Connect #159

breyed opened this issue Mar 4, 2015 · 8 comments

Comments

@breyed
Copy link
Contributor

breyed commented Mar 4, 2015

The following Quickstart text has a broken link:

Note: when you need to pass the mock for consumption, you must use the mock.Object accessor as a consequence of a C# compiler restriction (vote to get it removed at Microsoft Connect)

@kzu
Copy link
Member

kzu commented Mar 5, 2015

You can trivially edit it and send a PR with a fix right from the web ;)

/kzu from mobile

On Mar 4, 2015 4:45 PM, "Edward Brey" notifications@github.com wrote:

The following Quickstart https://github.com/Moq/moq4/wiki/Quickstart
text has a broken link:

Note: when you need to pass the mock for consumption, you must use the
mock.Object accessor as a consequence of a C# compiler restriction (vote
to get it removed at Microsoft Connect
https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=318122
)

Reply to this email directly or view it on GitHub
#159.

@breyed
Copy link
Contributor Author

breyed commented Mar 5, 2015

I don't know what the correct URL would be.

@kzu
Copy link
Member

kzu commented Mar 5, 2015

Connect is dead, so we might as well just delete the thing :)

/kzu from mobile

On Mar 4, 2015 9:40 PM, "Edward Brey" notifications@github.com wrote:

I don't know what the correct URL would be.

Reply to this email directly or view it on GitHub
#159 (comment).

@breyed
Copy link
Contributor Author

breyed commented Mar 5, 2015

Connect is not dead. I can log into the dashboard and see the dozen bugs I've reported that they've fixed and more importantly my 11 bugs that are still active (examples: 1, 2, 3).

Perhaps you are referring to suggestions, which used to be hosted on Connect, but have since moved to UserVoice. Do you know if the compiler restriction referred to is one of these?

@stakx
Copy link
Contributor

stakx commented Jun 4, 2017

I cannot find the issue on the search page you mentioned.

The feedback in question must have been about allowing implicit conversions from Mock<T> to T so one wouldn't have to write mock.Object, one could just let C# so an implicit conversion.

I assume that these days, one would ask for C# / VB.NET language features over at https://github.com/dotnet/roslyn/issues. Unfortunately, they currently have over 3,000 open issues. If anyone can track down a Roslyn issue that, if followed up on, would enable Moq to drop the mock.Object workaround, please report the issue link here.

In the meantime, perhaps it would really be best to just remove the broken link from the quickstart page.

@kzu
Copy link
Member

kzu commented Jun 4, 2017 via email

@stakx
Copy link
Contributor

stakx commented Jun 4, 2017

Will do.

@stakx
Copy link
Contributor

stakx commented Jun 5, 2017

Done.

@stakx stakx closed this as completed Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants