Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock.Protected().Verify method group has no overloads with bool exactParameterMatch #752

Closed
stakx opened this issue Feb 20, 2019 · 1 comment
Closed

mock.Protected().Verify method group has no overloads with bool exactParameterMatch #752

stakx opened this issue Feb 20, 2019 · 1 comment
Labels
enhancement
Milestone
4.11.0

Comments

@stakx
Copy link
Contributor

stakx commented Feb 20, 2019

This is a continuation of #735 (comment). In #751 we added a missing method overload to the mock.Protected().Setup method group that gives users the option to specify bool exactParameterMatch for non-void methods.

What is likely needed to solve the problem reported in #735 (comment) is similar additional overloads for the mock.Protected().Verify method group.

/cc @Shereef
@stakx stakx mentioned this issue Feb 20, 2019
Closed
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 20, 2019
@Shereef
Fixed devlooped#752 and added test/fact for it
e12a959
@Shereef
Copy link
Contributor

Shereef commented Feb 20, 2019

Thanks for your feedback it all makes sense.

P.S. the virtual part I had in my original project I just forgot it while making the test here, I have updated it and created a PR with the fix, if you have feedback please don't hesitate.

@Shereef Shereef mentioned this issue Feb 20, 2019
Merged
@stakx stakx added this to the 4.11.0 milestone Feb 20, 2019
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added failing unit test for devlooped#752 mock.Protected().Verify m…
a5c9b74 
…ethod group has no overloads with `bool exactParameterMatch`
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added overloads for mock.Protected().Verify and `mock.Protected().V…
03a54f4 
…erify<TResult>` with `bool exactParameterMatch` devlooped#752
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added a changelog entry for the change devlooped#752
91c809c
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added failing unit test for devlooped#752 mock.Protected().Verify m…
66ca83c 
…ethod group has no overloads with `bool exactParameterMatch`
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added overloads for mock.Protected().Verify and `mock.Protected().V…
432aa22 
…erify<TResult>` with `bool exactParameterMatch` devlooped#752
Shereef added a commit to Shereef/moq4 that referenced this issue Feb 21, 2019
@Shereef
Added a changelog entry for the change devlooped#752
dc4465e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
2 participants
@stakx @Shereef