Clean up setup execution method #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Invocation` expects to be "terminated" by a call to any of its `Return` methods, yet that currently never happens for `void` methods that have a setup but no further behavior configured. Add the missing call. The necessary guard condition is more complex than it needs to be, let's clean that up in the following commits.
Moving `raiseEventResponse` further up should be safe because the call to `invocation.CallBase()` it now precedes can only happen for `void` methods, and the fluent API doesn't actually permit simultaneous use of `Raises` and `CallBase` for `void` methods.
This change shouldn't be noticeable since the fluent API already does not allow a second `Callback` on `void` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This was triggered by the addition of a missing call to
invocation.Return()in order to terminate avoidmethodInvocation.)