Remove superfluous Convert nodes added by VB.NET in cases involving constrained generic type parameters
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
superfluous-vb-conversion-exprs
branch
2 times, most recently
from
a9092a2
to
4f807e8
Compare
It appears that VB.NET adds a pair of `Convert` nodes to expression trees for constrained generic type parameters. Those double conversions can end up "hiding" matchers thus wrapped from Moq's `MatcherFactory`.
The existing code in `MatcherFactory` unwraps only one conversion node to get at matchers etc. This is not enough in the scenario documented in the previous commit's failing test, which causes two conversion nodes to be present. This bug fix assumes that any conversion nodes present are only there to satisfy the compiler's static type checks, but that they are irrele- vant (and can thus be removed) for any analysis that needs to be done to identify a suitable matcher. (It might be safer to not simply remove any conversion node blindly, but instead target this very specific VB.NET pattern and deal with it as a special case.)
stakx
force-pushed
the
superfluous-vb-conversion-exprs
branch
from
4f807e8
to
c171d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1067.
I'll probably have to run a few more checks on whether it's really safe to blindly remove all type conversion nodes in
MatcherFactorybefore merging this.