Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating System.Threading.Tasks.Extensions to 4.5.4 #1108

Merged

Conversation

JeffAshton
Copy link
Contributor

@JeffAshton JeffAshton commented Nov 25, 2020

Fix for issue #1107

@stakx
Copy link
Contributor

stakx commented Nov 25, 2020

Thanks. I'd like to wait a little and see if they push another release of that library in the next few days; increasing the build number might have been a mistake that they're possibly going to fix. If they won't, I'll merge this.

@JeffAshton
Copy link
Contributor Author

@stakx, so this strong version bump did not happen recently. v4.5.3 was released on 7/9/2019, and v4.5.4 early 2020.

Up until now it's merely been an inconvenience. Not many of the standard libraries depend on this package. But with the release of net 5, consumers of this library's dependency System.Runtime.CompilerServices.Unsafe have been upgraded. For example, System.Collections.Immutable has a dependency chain back to the next strong version of System.Runtime.CompilerServices.Unsafe.

Do you have a sense of how long you want to wait? I'm also surprised they didn't release a 5.0.0, but it looks like everything that was going to get updated had a few months of previews and RCs, but System.Threading.Tasks.Extensions has been quiet.

@stakx
Copy link
Contributor

stakx commented Nov 25, 2020

I was under the impression that this was a relatively recent change since we only just got a report about it now; but if it's been that way for a while, there's probably no point in waiting.

@JeffAshton
Copy link
Contributor Author

I was under the impression that this was a relatively recent change since we only just got a report about it now; but if it's been that way for a while, there's probably no point in waiting.

I'm surprised it never got updated. Some packages above it did:

Microsoft.Bcl.AsyncInterfaces (5.0.0)
  -> System.Threading.Tasks.Extensions (4.5.4)
      -> System.Runtime.CompilerServices.Unsafe (4.5.3)

And there is a v5.0.0 of System.Runtime.CompilerServices.Unsafe, but System.Threading.Tasks.Extensions and System.Memory haven't been updated yet to consume it.

I think there is value in having a version of Moq that points at v4.5.4 of System.Threading.Tasks.Extensions, even if short lived, to help bridge this net5.0 gap. Given examples like the one above and this one:

System.Collections.Immutable (5.0.0)
  -> System.Memory (4.5.4)
      -> System.Runtime.CompilerServices.Unsafe (4.5.3)

Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go. Could you please also add a changelog entry at the top of CHANGELOG.md:

The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).


+## Unreleased
+
+#### Changed
+
+* Upgraded `System.Threading.Tasks.Extensions` dependency to version 4.5.4 (@JeffAshton, #1108)
+
+
 ## 4.15.1 (2020-11-10)

@stakx stakx merged commit 89c116f into devlooped:master Nov 25, 2020
@stakx
Copy link
Contributor

stakx commented Nov 25, 2020

Let's do this! 🚀 😉

@JeffAshton
Copy link
Contributor Author

Thanks @stakx for the quick turnaround.

@JeffAshton JeffAshton deleted the System.Threading.Tasks.Extensions-4.5.4 branch November 25, 2020 21:06
mburumaxwell pushed a commit to faluapp/falu-dotnet that referenced this pull request Jun 12, 2021
Bumps [Moq](https://github.com/moq/moq4) from 4.14.7 to 4.15.2.

#Changelog

*Sourced from [Moq's changelog](https://github.com/moq/moq4/blob/master/CHANGELOG.md).*

> ## 4.15.2 (2020-11-26)
>
> #### Changed
>
> * Upgraded `System.Threading.Tasks.Extensions` dependency to version 4.5.4 (@JeffAshton, [#1108](devlooped/moq#1108))
>
>
> ## 4.15.1 (2020-11-10)
>
> #### Added
>
> * New method overloads for `It.Is`, `It.IsIn`, and `It.IsNotIn` that compare values using a custom `IEqualityComparer<T>` (@weitzhandler, [#1064](devlooped/moq#1064))
> * New properties `ReturnValue` and `Exception` on `IInvocation` to query recorded invocations return values or exceptions (@MaStr11, [#921](devlooped/moq#921), [#1077](devlooped/moq#1077))
> * Support for "nested" type matchers, i.e. type matchers that appear as part of a composite type (such as `It.IsAnyType[]` or `Func<It.IsAnyType, bool>`). Argument match expressions like `It.IsAny<Func<It.IsAnyType, bool>>()` should now work as expected, whereas they previously didn't. In this particular example, you should no longer need a workaround like `(Func<It.IsAnyType, bool>)It.IsAny<object>()` as originally suggested in [#918](devlooped/moq#918). (@stakx, [#1092](devlooped/moq#1092))
>
> #### Changed
>
> * Event accessor calls (`+=` and `-=`) now get consistently recorded in `Mock.Invocations`. This previously wasn't the case for backwards compatibility with `VerifyNoOtherCalls` (which got implemented before it was possible to check them using `Verify{Add,Remove}`). You now need to explicitly verify expected calls to event accessors prior to `VerifyNoOtherCalls`. Verification of `+=` and `-=` now works regardless of whether or not you set those up (which makes it consistent with how verification usually works). (@80O, @stakx, [#1058](devlooped/moq#1058), [#1084](devlooped/moq#1084))
> * Portable PDB (debugging symbols) are now embedded in the main library instead of being published as a separate NuGet symbols package (`.snupkg) (@kzu, [#1098](devlooped/moq#1098))
>
> #### Fixed
>
> * `SetupProperty` fails if property getter and setter are not both defined in mocked type (@stakx, [#1017](devlooped/moq#1017))
> * Expression tree argument not matched when it contains a captured variable &ndash; evaluate all captures to their current values when comparing two expression trees (@QTom01, [#1054](devlooped/moq#1054))
> * Failure when parameterized `Mock.Of<>` is used in query comprehension `from` clause (@stakx, [#982](devlooped/moq#982))
>
>
> ## 4.15.0
>
> This version was accidentally published as 4.15.1 due to an intermittent problem with NuGet publishing.

#Commits

- [`f2aa090`](devlooped/moq@f2aa090) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants