Refactor SetupCollection towards a smaller & more consistent set of methods
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By accepting a `Setup` predicate instead of an `Invocation`, the method becomes more generally useful. Adding `Last` to the name clarifies that the collection will be searched in reverse order. This needs to be clarified because some methods process the collection in forward order, while others do the opposite. The name change also makes `SetupCollection` more similar to regular .NET collections (see e.g. `List<>.FindLast`).
The name change makes `SetupCollection` more similar to regular .NET collections (see e.g. `List<>.FindAll`). The method now also filters out overridden setups by default, just like `FindLast`. The new name is thus a hint that both methods work in a similar fashion.
This was only used in `HandleWellKnownMethods` to check for the presence of setups for `object` methods. `FindAndExecuteMatchingSetup` is looking for setups using `FindLast`; do it the same way here.
This makes the `TryFind` extension methods more uniform.
The new method ought to be more efficient, too, since only one active, non-conditional setup can ever match an invocation or invocation shape; so it is sufficient to consider only that setup's inner mock, instead of fetching all inner mock setups beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.