Make TPL code Silverlight 5 compatible #148
Conversation
|
Do we still need this? The SL is already 5.0, not sure we need to rebase this PR to get it in? |
|
I think we still need this. I've rebased PR. |
| @@ -239,4 +242,11 @@ | |||
| </FlavorProperties> | |||
| </VisualStudio> | |||
| </ProjectExtensions> | |||
| <Import Project="$(SolutionDir)\.nuget\NuGet.targets" Condition="Exists('$(SolutionDir)\.nuget\NuGet.targets')" /> | |||
There was a problem hiding this comment.
I'm fine moving to Castle nuget, but let us not go down the old nuget restore rabbit whole ;)
|
Removed Nuget restore. |
| @@ -21,6 +21,8 @@ | |||
| <AssemblyOriginatorKeyFile>..\Moq.snk</AssemblyOriginatorKeyFile> | |||
| <SignManifests>false</SignManifests> | |||
| <OldToolsVersion>4.0</OldToolsVersion> | |||
| <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir> | |||
There was a problem hiding this comment.
these two properties are part of nuget restore and should be gone too
|
Hm.. the main csproj has them, so merging :) |
Make TPL code Silverlight 5 compatible
|
I've created fix without them. Should I create new PR or will you leave this NuGet properties? |
|
leave them there, no worries. thanks for the fix! On Wed, Aug 12, 2015 at 11:58 PM Igor Kiselev notifications@github.com
|
Per discussion in #66, Silverlight 4 support was dropped and added TPL Task support to SL5 version. #70 just disabled TPL Task support for Silverlifht version, this PR re-enable it.