Fix NullReferenceException when passing null to a nullable argument but trying to match it with a non-nullable IsAny. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut trying to match it with a non-nullable IsAny. This fixes issue #90. The problem was that Matches() has to cast its input to the type parameter T in order to call the Condition function. Since T is a reference type, it does not accept nulls and throws a NullReferenceException at the site of the cast. We get around this by treating value types as a special case. If T is a value type and the input is null, it clearly doesn't match (since value types are not nullable).
kzu
added a commit
that referenced
this pull request
Mar 10, 2015
…ptionFromIsAny Fix NullReferenceException when passing null to a nullable argument but trying to match it with a non-nullable IsAny.
|
This seem to back as of latest v. 4.2.1506.2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #90.
The problem was that
Matches()has to cast its input to the type parameterTin order to call theConditionfunction.Since
Tis not a reference type, it does not accept nulls and throws aNullReferenceExceptionat the site of the cast.We get around this by treating value types as a special case inside
Matches. IfTis a value type and the input is null, it clearly doesn't match (since value types are not nullable).