Fix using Mock.Of on objects having properties with private setters #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great clean fix. Thanks! |
kzu
added a commit
that referenced
this pull request
Jun 21, 2012
Fix using Mock.Of on objects having properties with private setters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
I think my fix is valid (I'm basically converting to SetupGet when the setter is private).
@danielkzu the problem was that in MockSetupsBuilder, the
property.DeclaringTypeis the real type (Moq.Tests.Foo), whereas inSetupPropery, the type on which we work is theFooProxy. I think there is something going on in DynamicProxy2 (something like: when the setter of a property is private, it's not proxied in the proxy class).